'use client'; import { type FormEvent, useEffect, useMemo, useRef, useState } from 'react'; import { useTranslations } from 'next-intl'; import { updateWidgetConfig } from '@/lib/dashboard-api'; import { createFavorite, deleteFavorite, fetchFavorites, reorderFavorites, updateFavorite, type FavoriteLink, } from '@/lib/favorites-api'; import type { WidgetProps } from '@/components/dashboard/widget-registry'; // quick-260916-iex: wie DEBOUNCE_MS im Notiz-Widget const TITLE_DEBOUNCE_MS = 1500; /** * FavoritesWidget — persistent per-widget list of favorite links (DASH-09). * * Features: * - Loads favorites scoped to this widget instance via instanceId (Pitfall 3) * - Add / edit / delete in edit mode with inline forms * - List view (default, D-03) and grid view switchable in edit mode * - Server-side icon discovery (letter fallback when iconUrl is null) * - Links open in new tab with rel="noreferrer" (T-08-08 open-redirect mitigation) * - No dangerouslySetInnerHTML (T-08-07 XSS mitigation) * - Optionaler Titel (quick-260916-iex): leer -> keine Kopfzeile, sonst * Kopfzeile im Notiz-Look; im Bearbeitungsmodus immer ein Titelfeld, * entprellt gespeichert (Muster note-widget.tsx) * - Symbol-Ersatzweg (260917-jdd): FavoriteIcon versucht zuerst den Server- * Proxy, bei Fehler den Browser direkt (`onError`-Kette), zuletzt den * Buchstaben-Platzhalter * - Sortierung per Pfeilen im Bearbeitungsmodus (260917-jdd): optimistisch, * persistiert ueber PUT /favorites/order */ export function FavoritesWidget({ instanceId, config, isEditMode, }: WidgetProps) { const t = useTranslations('widgets'); const [favorites, setFavorites] = useState([]); const [loading, setLoading] = useState(true); const [error, setError] = useState(null); // View mode: read from config, default 'list' (D-03) const [viewMode, setViewMode] = useState<'list' | 'grid'>( (config.viewMode as 'list' | 'grid') ?? 'list', ); // Optionaler Titel (quick-260916-iex) const [title, setTitle] = useState( typeof config.title === 'string' ? config.title : '', ); const titleTimerRef = useRef | undefined>( undefined, ); useEffect(() => { return () => clearTimeout(titleTimerRef.current); }, []); function handleTitleChange(e: React.ChangeEvent) { const value = e.target.value; setTitle(value); clearTimeout(titleTimerRef.current); titleTimerRef.current = setTimeout(() => { void updateWidgetConfig(instanceId, { title: value }); }, TITLE_DEBOUNCE_MS); } const hasTitle = title.trim() !== ''; const showHeader = isEditMode || hasTitle; // Add-form state const [newTitle, setNewTitle] = useState(''); const [newUrl, setNewUrl] = useState(''); const [newIconUrl, setNewIconUrl] = useState(''); // Inline edit state const [editingId, setEditingId] = useState(null); const [editTitle, setEditTitle] = useState(''); const [editUrl, setEditUrl] = useState(''); const [editIconUrl, setEditIconUrl] = useState(''); // Sorted favorites: position asc, then title asc const sortedFavorites = useMemo( () => [...favorites].sort((a, b) => { if (a.position !== b.position) return a.position - b.position; return a.title.localeCompare(b.title); }), [favorites], ); // Befund 14 (quick-260921-gof): Ersatztext vor dem Effekt bestimmt, `t` // selbst bleibt aussen vor — die Testattrappe liefert bei jedem Durchlauf // eine frische Funktion, das wuerde den Mount-Abruf zur Schleife machen. const favoritesErrorText = t('favorites.error'); useEffect(() => { let cancelled = false; async function load() { setLoading(true); setError(null); try { const data = await fetchFavorites(instanceId); if (!cancelled) setFavorites(data); } catch { if (!cancelled) setError(favoritesErrorText); } finally { if (!cancelled) setLoading(false); } } void load(); return () => { cancelled = true; }; }, [instanceId, favoritesErrorText]); function getFallbackLetter(title: string): string { const clean = title.trim(); return clean ? clean.slice(0, 1).toUpperCase() : '?'; } // --- View mode toggle (edit mode only, D-03) --- function handleViewMode(next: 'list' | 'grid') { setViewMode(next); void updateWidgetConfig(instanceId, { viewMode: next }); } // --- Sortierung per Pfeilen (260917-jdd) --- async function handleMove(id: string, direction: 'up' | 'down') { const order = sortedFavorites.map((f) => f.id); const index = order.indexOf(id); const target = direction === 'up' ? index - 1 : index + 1; if (index < 0 || target < 0 || target >= order.length) return; [order[index], order[target]] = [order[target], order[index]]; const byId = new Map(favorites.map((f) => [f.id, f])); const reindexed = order.map((fid, i) => ({ ...byId.get(fid)!, position: i })); setFavorites(reindexed); setError(null); try { setFavorites(await reorderFavorites(instanceId, order)); } catch { setError(t('favorites.error')); try { setFavorites(await fetchFavorites(instanceId)); } catch { // Fehlermeldung steht bereits } } } // --- Add favorite --- async function handleAdd(e: FormEvent) { e.preventDefault(); const cleanTitle = newTitle.trim(); const cleanUrl = newUrl.trim(); const cleanIconUrl = newIconUrl.trim(); if (!cleanTitle || !cleanUrl) return; try { const created = await createFavorite({ widgetId: instanceId, title: cleanTitle, url: cleanUrl, iconUrl: cleanIconUrl || undefined, }); setFavorites((prev) => [...prev, created]); setNewTitle(''); setNewUrl(''); setNewIconUrl(''); } catch { setError(t('favorites.error')); } } // --- Edit favorite --- function startEdit(fav: FavoriteLink) { setEditingId(fav.id); setEditTitle(fav.title); setEditUrl(fav.url); setEditIconUrl(fav.iconUrl ?? ''); setError(null); } function cancelEdit() { setEditingId(null); setEditTitle(''); setEditUrl(''); setEditIconUrl(''); } async function handleSaveEdit(id: string) { const cleanTitle = editTitle.trim(); const cleanUrl = editUrl.trim(); const cleanIconUrl = editIconUrl.trim(); if (!cleanTitle || !cleanUrl) return; try { const updated = await updateFavorite(id, { title: cleanTitle, url: cleanUrl, iconUrl: cleanIconUrl || null, }); setFavorites((prev) => prev.map((f) => (f.id === id ? updated : f))); cancelEdit(); } catch { setError(t('favorites.error')); } } // --- Delete favorite --- async function handleDelete(id: string) { try { await deleteFavorite(id); setFavorites((prev) => prev.filter((f) => f.id !== id)); if (editingId === id) cancelEdit(); } catch { setError(t('favorites.error')); } } // --- Render --- return (
{/* Header: optional title (quick-260916-iex) — mirrors note-widget.tsx look */} {showHeader && (
{isEditMode ? ( ) : ( hasTitle && (

{title.trim()}

) )}
)}
{/* View mode toggle (edit mode only) */} {isEditMode && ( // role="toolbar" (D-03): die bisherige Beschriftung ("Favoriten") // war sachlich falsch fuer einen Umschalter zwischen Listen- und // Kachelansicht — hier greift D-03 im Sinn des Streichens (die // Beschriftung trug keine echte Bedeutung), eine richtige // Beschriftung ist trotzdem besser als gar keine.
)} {/* Status messages */} {loading && (

{t('favorites.loading')}

)} {error && (

{error}

)} {/* Favorites list / grid */} {!loading && sortedFavorites.length === 0 && (

{t('favorites.empty')}

)} {!loading && sortedFavorites.length > 0 && ( viewMode === 'grid' ? (
{sortedFavorites.map((fav, index) => ( 0} canMoveDown={index < sortedFavorites.length - 1} onMove={(fid, dir) => void handleMove(fid, dir)} t={t} /> ))}
) : (
{sortedFavorites.map((fav, index) => ( 0} canMoveDown={index < sortedFavorites.length - 1} onMove={(fid, dir) => void handleMove(fid, dir)} t={t} /> ))}
) )} {/* Add form (edit mode only, D-04) */} {isEditMode && (
void handleAdd(e)} className="flex flex-col gap-1 pt-1 border-t border-border widgetNoDrag" > setNewTitle(e.target.value)} placeholder={t('favorites.addTitle')} /> setNewUrl(e.target.value)} placeholder={t('favorites.addUrl')} />
)}
); } // --- Symbol-Ersatzweg (260917-jdd) --- /** * Leitet aus einer Favoriten-URL das direkte Browser-Favicon ab * (`{origin}/favicon.ico`) — nur fuer http:/https:, sonst null (kein * javascript:/data:, T-JDD-04). Wird ausschliesslich als Stufe 2 des * Ersatzwegs genutzt (siehe FavoriteIcon). */ function getDirectFaviconSrc(url: string): string | null { try { const u = new URL(url); if (u.protocol !== 'http:' && u.protocol !== 'https:') return null; return `${u.origin}/favicon.ico`; } catch { return null; } } /** * FavoriteIcon — dreistufiger Symbol-Ersatzweg (260917-jdd): * * 1. `proxy` — Server-Proxy (GET /favorites/:id/icon), der seit diesem Plan * auch bei Zertifikatsfehlern des Zielhosts liefert (undici-Dispatcher). * 2. `direct` — Direktbild aus dem Browser des Nutzers * (`referrerPolicy="no-referrer"`, Origin nur aus http/https); erreicht * interne Hosts, die der SSRF-Schutz des Servers absichtlich ablehnt. * 3. `none` — der Buchstaben-Platzhalter liegt IMMER darunter. * * Bewusst KEIN Drittanbieter-Favicon-Dienst: der wuerde Hostnamen nach * aussen geben und interne Hosts ohnehin nicht kennen. * * Befund am Code: `discoverFavoriteIconUrl` liefert NIE null, sondern bei * jedem Fehler den Origin-Rueckfall — die Stufe `direct` haengt deshalb an * `onError` des Proxy-Bildes UND an `iconUrl === null`, nicht nur an * letzterem. * * Grenzen: ein http-Favorit auf einem https-Tessera ist Mischinhalt * (Browser blockiert ihn); ein selbstsigniertes Zertifikat ohne Vertrauen * im Browser des Nutzers klappt auch ueber Stufe 2 nicht. */ function FavoriteIcon({ fav, getFallbackLetter, }: { fav: FavoriteLink; getFallbackLetter: (title: string) => string; }) { const proxySrc = fav.iconUrl ? `/api-proxy/favorites/${encodeURIComponent(fav.id)}/icon` : null; const directSrc = getDirectFaviconSrc(fav.url); const [stage, setStage] = useState<'proxy' | 'direct' | 'none'>( proxySrc ? 'proxy' : 'direct', ); return (
{getFallbackLetter(fav.title)} {stage === 'proxy' && proxySrc && ( setStage('direct')} /> )} {stage === 'direct' && directSrc && ( setStage('none')} /> )}
); } // --- FavoriteTile sub-component --- type FavoriteTileProps = { fav: FavoriteLink; isEditMode: boolean; editingId: string | null; editTitle: string; editUrl: string; editIconUrl: string; getFallbackLetter: (title: string) => string; onStartEdit: (fav: FavoriteLink) => void; onCancelEdit: () => void; onSaveEdit: (id: string) => Promise; onDelete: (id: string) => Promise; onEditTitleChange: (v: string) => void; onEditUrlChange: (v: string) => void; onEditIconUrlChange: (v: string) => void; canMoveUp: boolean; canMoveDown: boolean; onMove: (id: string, direction: 'up' | 'down') => void; t: (key: string) => string; }; function FavoriteTile({ fav, isEditMode, editingId, editTitle, editUrl, editIconUrl, getFallbackLetter, onStartEdit, onCancelEdit, onSaveEdit, onDelete, onEditTitleChange, onEditUrlChange, onEditIconUrlChange, canMoveUp, canMoveDown, onMove, t, }: FavoriteTileProps) { const isEditing = editingId === fav.id; return (
{/* Main link row */}
{/* Anchor — opens in new tab, no server-side redirect (T-08-08) */} isEditMode && e.preventDefault()} // block navigation in edit mode > {/* Icon container with letter fallback (T-08-07 — no dangerouslySetInnerHTML) */} {fav.title} {/* Action buttons (edit mode only, D-04) */} {isEditMode && !isEditing && (
{/* Sortierpfeile (260917-jdd) — kein Drag & Drop hier, das kollidiert mit dem Ziehen der Kachel in react-grid-layout */}
)}
{/* Inline edit form */} {isEditMode && isEditing && (
onEditTitleChange(e.target.value)} placeholder={t('favorites.addTitle')} /> onEditUrlChange(e.target.value)} placeholder={t('favorites.addUrl')} /> onEditIconUrlChange(e.target.value)} placeholder="Logo-URL (optional)" />
)}
); }